chore: back-merge master into develop (v1.4.11 windows installer fix)#333
Merged
Conversation
release: v1.4.5 — swap UX, custom fees, build reliability fixes
release: v1.4.6 — Zcash shielded hardening + Windows installer fix
release: v1.4.10 — LTC portfolio stability, UTXO audit recovery, XRP REST signing, Hive onboarding
release: v1.4.11 — Hyperliquid EIP-712 colon-namespaced typed-data signing fix
…ck it The default single-exe Inno installer self-extracts an UNSIGNED setup.tmp engine to %TEMP% and runs it. Smart App Control (on by default on many Win11 machines) blocks unsigned code, so v1.4.11 died with "Setup failed to initialize" (exit 1, CodeIntegrity 3077/3033) and installed nothing. The EV signature on the outer setup.exe doesn't help — SAC evaluates the extracted setup.tmp on its own, and stock Inno can't sign it. The app binaries themselves are all EV-signed and SAC-clean; only the installer's extracted stub was the problem. Fix: - installer.iss: UseSetupLdr=no -> no setup.tmp; the signed setup.exe is the engine and runs in-process, so SAC only sees the signed exe. Inno now emits setup.exe + setup-*.bin. - build-windows-production.ps1: zip the parts into KeepKey-Vault-<ver>-win-x64-setup.zip and delete the loose exe/bin so a bare (SAC-blocked) single exe can't be shipped by accident. - docs: WINDOWS-BUILD-AND-SIGN.md gains a "Smart App Control" section and a MANDATORY "install under SAC (Enforce)" checklist item — SAC-off machines are an invalid test, which is how this slipped through (1.4.7 smoke test was SAC-off). Full write-up in docs/incidents/. Validated on a SAC-Enforce machine via the real download flow (zip + MotW -> extract -> run setup.exe): exit 0, version 1.4.11, no 3077/3033, app boots. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
release: v1.4.11 windows installer Smart App Control fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back-merges master after #332 (release/1.4.11 windows-installer Smart App Control fix landed post-release). Brings that commit into develop per the normal release-train flow (release branch -> master -> develop).